So protonup-qt was to comfortable for you to use?
post
I also wrote my own Python based installer, updater, manager of Proton GE (but do not post it here, as this is about your project and not mine). Years back when I posted it, people pointed out such a cli tool already existed: protonup. And for those who want a GUI, protonup-qt exists too.
rm -r $tempdir
This is extremely dangerous command! If anything goes wrong for whatever reason and the variable $tempdir is empty at the time of this command, then it would delete everything. At the very least you should do a check if variable is not empty and resolves to an existing directory. Better yet, make it multiple steps:
- check if variable is not empty
- check if variable resolves to a directory
- cd into the directory and delete content by name instead a variable, like
rm -r GE-Proton*and then cd .. back and delete empty directory withrmdir $tempdir
This is a more controlled way of deleting files. I admit that I am a bit paranoid with rm -r commands.
This is extremely dangerous command! If anything goes wrong for whatever reason and the variable $tempdir is empty at the time of this command, then it would delete everything.
And this danger is not merely theoretical. Steam for Linux did it in 2015.
https://github.com/valvesoftware/steam-for-linux/issues/3671
It's not dangerous in this case, if $tmpdir was unset, all that would happen is rm -r $tempdir complaining about a missing operand. The only issue I can see this causing is that if mktemp -d fails rm would print an unhelpful error message. Using rm -rf instead would hide it, so could could checking the variable and conditionally running rm -r, as you suggested.
Scripts and programs are edited all the time, either by its original author or for modifications when downloaded. Maybe the original author forgot something when editing and suddenly its no longer safe. Or $tempdir isn't a unique name, meaning at different places (be it copy paste) could manipulate the global variable. Human errors happen all the time. Better do check in place, instead hoping that this stays safe. Alternatively create a tempdir with a fixed part in name, like "${tempdir}_protonge".
Also, use set -euo pipefail (look at man set) in every script that's more than four lines. It would instantly fail and exit upon finding an unbound variable.
Which package do you talk about?
I don't know any Flatpak package in Flathub that is just called proton GE. Could you link to the it?
Probably referring to the add-on for Steam
I use ProtonPlus for updates. It be nice. Dev promised background updates soon, too.
all 22 comments