67
I made a better Proton GE installer and updater (forgejo.zeromedia.vip)
submitted 4 months ago by to c/linux_gaming@lemmy.world
19 comments fedilink hide all child comments
 

Hey everyone! I started working on this a month ago and then forgot about it after I finished v1.0. Today, I announce v2.0! This adds so many improvements and makes it so much more functional than before.

Ultimately, every time I updated Proton GE, I got more and more tired of having to keep going to github, downloading the latest archive, extracting it, restarting steam, and configuring it to use the new version. So I decided to automate it! You can now run this script, and it does everything for you, and so long as it's not the first time you've used it, you don't even have to restart steam!

Now, as I say in the README, the official GE-Proton repo gives an example of script that does something similar, but that example is intended as more of a one time thing, and I felt like I could make a more permanent script that also makes some functional improvements over their implementation.

I hope you all enjoy!

you are viewing a single comment's thread
view the rest of the comments
[–] 4 points 4 months ago (1 child)

It's not dangerous in this case, if $tmpdir was unset, all that would happen is rm -r $tempdir complaining about a missing operand. The only issue I can see this causing is that if mktemp -d fails rm would print an unhelpful error message. Using rm -rf instead would hide it, so could could checking the variable and conditionally running rm -r, as you suggested.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 1 child comment
    •
  • [–] 8 points 4 months ago

    Scripts and programs are edited all the time, either by its original author or for modifications when downloaded. Maybe the original author forgot something when editing and suddenly its no longer safe. Or $tempdir isn't a unique name, meaning at different places (be it copy paste) could manipulate the global variable. Human errors happen all the time. Better do check in place, instead hoping that this stays safe. Alternatively create a tempdir with a fixed part in name, like "${tempdir}_protonge".

  • permalink
  • fedilink
  • source
  • parent