507
CompareBooleans (sh.itjust.works)
submitted 8 months ago by [email protected] to c/[email protected]
top 50 comments
sorted by: hot top new old
[-] [email protected] 107 points 8 months ago

Wait areBooleanEqual returns false when they are equal?

[-] [email protected] 10 points 8 months ago

That's not even the worst part. What the fuck does a function named Compare_anything do? Does it return anything? It sounds like nothing but a side effect.

[-] [email protected] 11 points 8 months ago

Usually comparison functions are supposed to return an integer and are usually useful for sorting. However this one returns a bool so it's both useless and terribly named.

[-] [email protected] 7 points 8 months ago

The unnecessary and confusing functions are horrible, yes, but I'd still say that the fact that they're wrong is the "worst" part.

load more comments (1 replies)
[-] [email protected] 85 points 8 months ago

Don’t forget the invocation

if (CompareBooleans(a, b) == true)
[-] [email protected] 60 points 8 months ago

if (CompareBooleans(CompareBooleans(a, b), true))

[-] [email protected] 11 points 8 months ago

I don't like this thread anymore :(

load more comments (1 replies)
load more comments (1 replies)
[-] [email protected] 18 points 8 months ago

elseif(CompareBooleans(b,a) != false)

[-] [email protected] 58 points 8 months ago

Management: Gee whiz, we really have no idea how to gauge productivity to decide who gets promoted. We could manage. Or, better, we could just have someone write a script that pulls info from git on how many lines of code each person has written.

Programmers:

[-] [email protected] 22 points 8 months ago

I promote based on lines of code removed.

[-] [email protected] 26 points 8 months ago

I quit based on idiotic metrics

[-] [email protected] 5 points 8 months ago

Ah, the idiotic idiotic metric metric.

load more comments (3 replies)
load more comments (3 replies)
[-] [email protected] 53 points 8 months ago

There’s no way, that’s so insane it has layers.

[-] [email protected] 18 points 8 months ago

At first, I thought the shitty methods were the joke 😱😱😱

[-] [email protected] 50 points 8 months ago

This is code after working 16 hours

[-] [email protected] 11 points 8 months ago

I'd give my right hand this is a code review problem. Someone extracted a method returning true false. Then an intern came along and was told to refactor. They saw a lot of comparisons and "extracted" them.

[-] [email protected] 7 points 8 months ago

My coworker made an array of book to express a status. This is no doing of an intern but a much eviler force at play.

load more comments (1 replies)
[-] [email protected] 30 points 8 months ago

Two wrongs don’t make a right, but sometimes in programming, two bugs can cancel each other out.

Whoever wrote this is more than capable of using it incorrectly.

[-] [email protected] 21 points 8 months ago

Is this part of Elons "How many lines of choice have you written?" interview?

[-] [email protected] 21 points 8 months ago* (last edited 8 months ago)

Those are rookie lines of code numbers right there.
I would have done it without the ==

internal static bool AreBooleansEqual(bool orig, bool val)
{
    if(orig) 
    {
        if(val)
            return false
        return true
    }
    if(val)
        return true 
    return false
}

Don't know why their code returns false when they are equal but I'm not going to dig through old code to refactor to use true instead of false.

[-] [email protected] 9 points 8 months ago

you can also use XOR operation

return (X || Y) && !(X && Y)
load more comments (1 replies)
load more comments (5 replies)
[-] [email protected] 18 points 8 months ago

You can tell they're amateurs. It's not obfuscated enough. They won't be able to keep their job.

[-] [email protected] 19 points 8 months ago

They clearly need an abstract boolean comparison factory.

[-] [email protected] 21 points 8 months ago* (last edited 8 months ago)
var CompareBooleans = new ComparatorFactory().BooleanComparator(new BooleanComparisonByEqualityPolicy());
if (CompareBooleans(a, b) == true) {
     System.Out.PrintLn("Sames!!!");
}

...

But now that I've written this, it's C#, so it's missing dependency injection.

[-] [email protected] 6 points 8 months ago

I can imagine Uncle Bob be proud of this Clean Code (TM)

[-] [email protected] 18 points 8 months ago

My guess to why there’s two functions is because it was originally only internal, and the programmer realized they needed public as well, but changing internal to public is too scary so they created a new method instead.

load more comments (1 replies)
[-] [email protected] 17 points 8 months ago

"We need to obfuscate our code to prevent reverse engineering"

The obfuscation in question:

load more comments (2 replies)
[-] [email protected] 17 points 8 months ago
[-] [email protected] 7 points 8 months ago
load more comments (1 replies)
[-] [email protected] 5 points 8 months ago

I can definitely understand why they did that but it's still very funny

load more comments (8 replies)
[-] [email protected] 16 points 8 months ago

If this were a Node module, I wouldn't even be surprised.

[-] [email protected] 14 points 8 months ago

Clearly it should be return orig == val

Duh

[-] [email protected] 34 points 8 months ago

To match the current behavior it should be orig != val

load more comments (1 replies)
[-] [email protected] 13 points 8 months ago

I'm a bit disappointed there isn't a call to GetBooleanValue in there

[-] [email protected] 9 points 8 months ago

!NOT

Who's there?

!!Naughty Knots

[-] [email protected] 8 points 8 months ago

But how do you test for FILE_NOT_FOUND?

[-] [email protected] 8 points 8 months ago

Where are the unit tests?

[-] [email protected] 7 points 8 months ago

Straight from the famous book "Making LOCs for Dummies"

[-] [email protected] 6 points 8 months ago

I misread it as CompareBolians. No more Star Trek memes for me today.

[-] [email protected] 5 points 8 months ago

Many Bolians died bringing us this information.

[-] [email protected] 6 points 8 months ago
[-] [email protected] 5 points 8 months ago

WTAF? Is this written by a hallucinating AI?

load more comments (3 replies)
[-] [email protected] 5 points 8 months ago

Thanks I hate it

load more comments
view more: next ›
this post was submitted on 28 Oct 2024
507 points (98.3% liked)

Programming Humor

3211 readers
1 users here now

Related Communities [email protected] [email protected] [email protected] [email protected]

Other Programming Communities [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected]

founded 2 years ago
MODERATORS