68
submitted 2 years ago* (last edited 2 years ago) by [email protected] to c/[email protected]

As reported to the lemmy devs here there is no sanity checking of links in posts currently in lemmy. Please be careful in the links you click!

Further discussion and context from the reporter here.

top 16 comments
sorted by: hot top new old
[-] [email protected] 9 points 2 years ago

I really wish jerboa could show urls on links for this reason. Are there any other Android clients that do?

[-] [email protected] 4 points 2 years ago

I'm sad that the RIF dev is making a Tildes app next, because the RIF UX around links was absolutely spectacular.

[-] [email protected] 4 points 2 years ago

Connect doesn't appear to be.

[-] [email protected] 3 points 2 years ago* (last edited 2 years ago)

It does in card and full width view, just not in list or reverse list view based on my testing just now.

Edit: It shows the domain at least. Jerboa does too in every view in 0.0.38 as far as I can tell.

[-] [email protected] 2 points 2 years ago

Do the android apps have this issue? What would they even do with a JavaScript link?

[-] [email protected] 1 points 2 years ago

Links in post body and comments don't show URLs so they could easily send ya to a malware site or gore/NSFW/IP logger site.

[-] [email protected] 2 points 2 years ago

True but op is talking about JavaScript links.

[-] [email protected] 3 points 2 years ago* (last edited 2 years ago)

Liftoff shows the domain the link is going to, but not the entire URL. And it only shows up when going to the comments.

[-] [email protected] 1 points 2 years ago* (last edited 2 years ago)

Good enough! I'll switch to Liftoff today

EDIT: Liftoff isn't showing any website/url previews for the links in the post or comment text but it's working for primary URLs of posts so it's better than nothing lol

EDIT2: Actually Liftoff doesn't do anything more than Jerboa already does. It seems Boost can show URLs before opening a link but it is closed source.

Jerboa feature request: https://github.com/dessalines/jerboa/issues/434

[-] [email protected] 4 points 2 years ago* (last edited 2 years ago)

checks

It looks like kbin does check for and validate these. It hands back an "invalid URL" error if the mentioned javascript: schema in the bug report for lemmy is used.

EDIT: Though I didn't try submitting to a lemmy instance and seeing whether kbin validates links coming in from federated systems rather than locally-submitted.

EDIT2: Honestly, this should be checked in clients too to avoid a malicious server they connect to directly feeding them XSS URLs. Like, probably warrants bug reports for all clients.

[-] [email protected] 4 points 2 years ago

Sure thanks... Wait a minute.

[-] [email protected] 4 points 2 years ago

I'm gonna be so disappointed if at least one of those links is not a rickroll lol

[-] [email protected] 2 points 2 years ago

I would be but my school IT taught me better.

[-] [email protected] 3 points 2 years ago

Yikes. Thanks for the heads up.

[-] [email protected] 3 points 2 years ago

Even with the PWA it's tricky to check.

It's out there now. Needs a hotfix.

[-] [email protected] 1 points 2 years ago

Unpinning this, as lemmy 0.18.1 includes this update that limits URL links to only being http(s).

Everyone should still be wary of clicking random links on the internet of course.

load more comments
view more: next ›
this post was submitted on 06 Jul 2023
68 points (98.6% liked)

Meta

681 readers
1 users here now

Discussion about the aussie.zone instance itself

founded 2 years ago
MODERATORS