If you put an underscore as the first character in the variable name, that tells the compiler that the variable may go unused and you're okay with that. E.g.
let mut _last = &mut first;
this post was submitted on 13 Mar 2024
11 points (100.0% liked)
Rust
5931 readers
15 users here now
Welcome to the Rust community! This is a place to discuss about the Rust programming language.
Wormhole
Credits
- The icon is a modified version of the official rust logo (changing the colors to a gradient and black background)
founded 1 year ago
MODERATORS
That's a neat trick!
I knew it worked for params, but never thought to use it for variables.
The issue is related to the binding being reassigned then never used. It's happening because they're using code generation where the final loop doesn't need to assign. (but previous loops use the assignment at the loop start. Just throwing all that in a function and adding the warning suppression fixes it.
edit: I'm wrong, using an underscore works
A hack would be to do a simple noop read, like:
if last.is_some() {}
first
The problem seems to be the last last = last_mut.cdr;, since you don't use it on the last iteration.
I'd personally do that with a comment until you (or someone else) can fix it, perhaps with a linter instruction at some point. That noop code should be eliminated during the optimization step, so it shouldn't hurt performance or anything.
Edit: don't do this, just prefix the variable with an underscore as someone else mentioned.
I'm not sure if the rules are different with macros, I've never written one but this lint is generally caused because you set a var to a value and then overwrite that value before you use it. e.g.
let mut a = 1; a = 2; println!("{}", a);
This will throw the same warning because 1 is never used, this could've just been:
let a = 2; println!("{}", a);
So first I'd double check that I NEED last at all. Maybe try:
cargo clippy
See if it can tell you how to fix it.
If that doesn't work, it's sometimes necessary to skip certain lints. E.g. if you make a library, most of the code will be flagged as dead code because it isn't used and you can use an #[allow(dead_code)] to stop the linter warning. You might be able to use #[allow(this_linting_rule)].
Hope something here helps.
Clippy didn't tell anything about the macro.
warning: dereferencing a tuple pattern where every element takes a reference
--> src/lib.rs:13:9
|
13 | &Some(ref cons_rc) => {
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
= note: `#[warn(clippy::needless_borrowed_reference)]` on by default
help: try removing the `&` and `ref` parts
|
13 - &Some(ref cons_rc) => {
13 + Some(cons_rc) => {
|
To put #[allow(this_linting_rule)] like this:
[ $x:expr, $( $y:expr ),* ] => {
#[allow(unused_assignments)]
{
I got error[E0658]: attributes on expressions are experimental.
To put it like this:
#[macro_export]
#[allow(unused_assignments)]
macro_rules! list {
() => {
None
It doesn't work.
I would expect the following to work
#[allow(unused)]
let mut last = &mut first;
It doesn't work, at least, on rustc 1.75.
I misunderstood the reason the error was showing up. It seems like using a closure fixes it though.
#[macro_export]
macro_rules! list {
() => {
None
};
[ $x:expr, $( $y:expr ),* ] => {{
#[allow(unused_assignments)]
let closure = move || {
let mut first = cons($x, &None);
let mut last = &mut first;
$(
let yet_another = cons($y, &None);
if let Some(ref mut last_inner) = last {
let last_mut = Rc::get_mut(last_inner).unwrap();
last_mut.cdr = yet_another;
last = &mut last_mut.cdr;
}
)*
first
};
closure()
}}
}
#[allow(unused_assignments)]
Thank you. This works!