Rust

5931 readers

15 users here now

Welcome to the Rust community! This is a place to discuss about the Rust programming language.

Wormhole

[email protected]

Credits

The icon is a modified version of the official rust logo (changing the colors to a gradient and black background)

founded 1 year ago

MODERATORS

[email protected]

How can I avoid "value assigned to last is never read" warning from this macro? (lemmy.one)

submitted 7 months ago by [email protected] to c/[email protected]

10 comments fedilink hide all child comments

Removing last will break my library.

#[macro_export]
macro_rules! list {
    () => {
	None
    };
    [ $x:expr, $( $y:expr ),* ] => {
	{
	    let mut first = cons($x, &None);
	    let mut last = &mut first;
	    $(
		let yet_another = cons($y, &None);
		if let Some(ref mut last_inner) = last {
		    let last_mut = Rc::get_mut(last_inner).unwrap();
		    last_mut.cdr = yet_another;
		    last = &mut last_mut.cdr;
		}
	    )*
	    first
	}
    }
}

This macro works as I expected because it can pass these tests.

    #[test]
    fn dolist() {
        let mut v = vec![];
        dolist!((i &cons(10, &list![20, 30, 40])) {
            v.push(i.car);
        });
        assert_eq!(v, vec![10, 20, 30, 40]);
    }

    #[test]
    fn turn_list_to_vec() {
        assert_eq!(list_to_vec(&list![1, 2, 3]), vec![1, 2, 3]);
    }

    #[test]
    fn count_elements() {
        assert_eq!(list_len(&list![10, 20, 30]), 3);
    }

However I got the warning "value assigned to last is never read."

How can I avoid this warning?

P.S. Full code

you are viewing a single comment's thread
view the rest of the comments

[–] [email protected] 2 points 7 months ago (1 children)

Clippy didn't tell anything about the macro.

warning: dereferencing a tuple pattern where every element takes a reference
  --> src/lib.rs:13:9
   |
13 |         &Some(ref cons_rc) => {
   |         ^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
   = note: `#[warn(clippy::needless_borrowed_reference)]` on by default
help: try removing the `&` and `ref` parts
   |
13 -         &Some(ref cons_rc) => {
13 +         Some(cons_rc) => {
   |

To put #[allow(this_linting_rule)] like this:

    [ $x:expr, $( $y:expr ),* ] => {
	#[allow(unused_assignments)]
	{

I got error[E0658]: attributes on expressions are experimental.

To put it like this:

#[macro_export]
#[allow(unused_assignments)]
macro_rules! list {
    () => {
	None

It doesn't work.

[–] [email protected] 1 points 7 months ago (1 children)

I would expect the following to work

#[allow(unused)]
let mut last = &mut first;

[–] [email protected] 1 points 7 months ago (1 children)

It doesn't work, at least, on rustc 1.75.

[–] [email protected] 2 points 7 months ago* (last edited 7 months ago) (1 children)

I misunderstood the reason the error was showing up. It seems like using a closure fixes it though.

https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=247730dfc1fbeeb8e2263ea3b95d6c0a

#[macro_export]
macro_rules! list {
    () => {
        None
    };
    [ $x:expr, $( $y:expr ),* ] => {{
        #[allow(unused_assignments)]
        let closure = move || {
            let mut first = cons($x, &None);
            let mut last = &mut first;

            $(
                let yet_another = cons($y, &None);
                if let Some(ref mut last_inner) = last {
                    let last_mut = Rc::get_mut(last_inner).unwrap();
                    last_mut.cdr = yet_another;

                    last = &mut last_mut.cdr;
                }
            )*

            first
        };

        closure()
    }}
}

[–] [email protected] 2 points 7 months ago

  #[allow(unused_assignments)]

Thank you. This works!