Programming

I'm a senior at a large tech company - I push all the teams I work with to automate the review process as much as possible. At minimum, teams must have a CI hook on their pull request process that runs a remote dryrun build of the changed packages. The dryrun makes sure the packages compile, pass unit tests and meet linter rules. A failed build blocks the pull request from being merged.

I try to encourage developers to turn the outcome of every code style discussion into a lint rule that fails the dryrun build when its violated.

At my work we use trunk based development, with mandatory review before merging (enforced by tooling). Part of the review is ensuring proper test coverage and it's enhanced by static code analysis.

Ours is pretty intense - large bank, 60 or so iOS engineers actively contributing to a mono-repo:

1. We have about 15 CI steps that pick up on anything from basic linting to security concerns (SonarQube). Unit tests, UI tests, etc.
2. We have a template that PR authors follow to add descriptions, test plans, devices tested on.
3. Reviewers are automatically assigned using a round robin system
4. Reviewers obviously review the code, but also execute the test plan, which includes accessibility testing.
5. All PRs require 2 approvals.
6. A bunch of other stuff (uploading artefacts, generating gRPC protos) that probably isn't worth going into detail.

It's intense, and PRs on average take a week or so to get merged. In saying that, it is the highest quality and most well-architected codebase I have ever worked on.

If I were in your situation I'd push for the following:

• all PRs have one approval, preferably two depending on team size
• code is tested by someone else before being merged to main
• use linters, Danger, etc to pick up on trivial shit
• a few manual checks like ensuring code is unit tested
• a Github PR Reviewer guide describing common issues to look for, tone of messaging when leaving comments ("be nice", "make it clear when you are adding optional nit-picks", etc)
• encourage authors to add review comments to their own PRs for any bit of code that isn't immediately obvious
• stretch goal: look into generating code coverage reports on your PRs, add quality gates

have you looked at Git Flow? Its pretty solid.

My team has a develop branch from which we branch feature branches. On it we commit our stuff and when we think its feature complete we build a snapshot version of it so that our QA can test it. Once that test was successful, and the code has been peer reviewed, it will be merged back onto develop.

PRs will be auto built so that the feature can be integrated and automated tested.