Programmer Humor

19623 readers

26 users here now

Welcome to Programmer Humor!

This is a place where you can post jokes, memes, humor, etc. related to programming!

For sharing awful code theres also Programming Horror.

Rules

Keep content in english
No advertisements
Posts must be related to programming or programmer topics

founded 1 year ago

MODERATORS

[email protected]

243

DO NOT MERGE (feddit.dk)

submitted 10 months ago by [email protected] to c/[email protected]

33 comments fedilink hide all child comments

Merged

you are viewing a single comment's thread
view the rest of the comments

[–] [email protected] 21 points 10 months ago (3 children)

Why did they submit this as a pull request in the first place? Just commit it to a WIP branch until it’s ready to merge. Am I missing something?

[–] [email protected] 30 points 10 months ago (1 children)

Probably to get some other benefitof the PR system, such as CI tests

[–] [email protected] 10 points 10 months ago (2 children)

Does gerrit have a draft state? In azure devops you can mark PR as draft , won't trigger any builds but you can still start them manually

[–] [email protected] 4 points 10 months ago

manually

This is probably why the dev created a PR, less clicks

[–] [email protected] 2 points 10 months ago

I don’t remember if it did when I used it. Our convention was to -2 your own change until it was ready to go 😅

[–] [email protected] 7 points 10 months ago

I do this often. It's useful if you want to send it to your coworker for some early feedback or as others have said, have the CI run

[–] [email protected] 4 points 10 months ago* (last edited 10 months ago)

It's been a while since I've worked with AOSP, but I had always understood it to be some weird shit with Google's internal processes. The "do not merge" commits are all over the AOSP, or at least they used to be.