xmunk comments on advanced

[–] xmunk@sh.itjust.works 9 points 2 years ago (6 children)

If you're in a language that supports it, please don't use if (false) use if ($disallowAllUsers = false && $whateverTheRealConditionIs)

[–] PlexSheep@feddit.de 6 points 2 years ago (2 children)

Never seen this, what language or buildsystem is this?

parent

[–] xmunk@sh.itjust.works 3 points 2 years ago* (last edited 2 years ago) (1 child)

That specific language is PHP, but the tip is applicable in any language that supports inline assignment.

parent

[–] TheOctonaut@mander.xyz 6 points 2 years ago

if (true === $wantToCauseErrorsForFun) {
    badOldFunction();
}

parent

[–] kogasa@programming.dev 1 point 2 years ago

The assignment syntax is too close to comparison, which is what is more typical in that position. I would recommend

const bool _isFeatureEnabled = false;
if (_isFeatureEnabled &amp;&amp; ...)

if not a proper feature flag (or just remove the code).

parent

[–] SpaceNoodle@lemmy.world -1 points 2 years ago (1 child)

It seems much worse to use a setter in an if statement.

parent

[–] xmunk@sh.itjust.works 0 points 2 years ago

Think of it as inline attribution/documentation.

parent