this post was submitted on 22 Oct 2023
619 points (95.7% liked)
Programmer Humor
32054 readers
1537 users here now
Post funny things about programming here! (Or just rant about your favourite programming language.)
Rules:
- Posts must be relevant to programming, programmers, or computer science.
- No NSFW content.
- Jokes must be in good taste. No hate speech, bigotry, etc.
founded 5 years ago
MODERATORS
you are viewing a single comment's thread
view the rest of the comments
view the rest of the comments
Thief way is actually the best among all of these imo, in terms of readability and efficiency.
Not using thief is professional incompetence unless you're doing something deeply cursed
Like pair programming.
Fr. People like to reimplement wheels tho
Sometimes you need to minimize function calls in a tight loop, but otherwise yeah
Why would you be using JS in this scenario?
Node.js, electron 🤷♂️
Something has gone horribly wrong if you're trying to do such optimisations when you've already chosen JavaScript...let alone Electron.
And yet it happens, just look at the molasses that is Teams
Thankfully the only interaction I have with teams is when a supplier arranges the call. Once every two weeks. It grosses me out every time...and that's the Web app.
Do you really think they have done such optimisation efforts as minimising function calls? I can't imagine it's required for what is actually a fairly simple frontend app. The complexity is the enabling stack on the backend.
Good answer.
Even if it made me throw up in my mouth a little. /s
Edit: Not the concept of Electron, itself - but being asked to write highly performant code in Electron.
I was under the impression that modern compilers just inline something like that, and even in older languages (like C) use trickeries are used to inline it (typically MAX is a macro rather than a real function, so its always inlined)
Ultimatelly it depends not just on what you're doing but also the language and compiler you're using.
If you're optimizing that hard you should probably sort the data first anyway, but yeah, sometimes it's absolutely called for. Not that I've actually needed that in my professional career, but then again I've never worked close enough to metal for it to actually matter.
That said, all of these are implemented as functions, so they're already costing the function call anyway...
Sometimes, but practically never. Just be a thief.
They’re setting a variable to a function. Just use the original function. All thief does is obfuscate for literally no gain except character count.
I presumed it to be a standin for just directly using Math.max, since there's no nice way to show that in a valid code snippet
well it's called Thief. They're stealing the function and making it look like they wrote it. hence
max1.Yeah, that's my reading as well.
Sounds good to me