this post was submitted on 02 Jul 2023
1148 points (98.4% liked)
Programmer Humor
19551 readers
1337 users here now
Welcome to Programmer Humor!
This is a place where you can post jokes, memes, humor, etc. related to programming!
For sharing awful code theres also Programming Horror.
Rules
- Keep content in english
- No advertisements
- Posts must be related to programming or programmer topics
founded 1 year ago
MODERATORS
you are viewing a single comment's thread
view the rest of the comments
view the rest of the comments
LGTM!
Let’s Gamble, Try Merging!
Why. Whyyyyyy people need to comment this always? Why isn't just the Approve button enough? I so much hate it.
Ah, that's too boring. I have a range of responses to pick from to keep things interesting:
For me, no text means "I haven't really reviewed this properly so don't want to write anything that could be used against me if (when?) this breaks something in prod"
:100:
I reserve "ship it" to mostly trivial bug fixes.
If you're in a place with codebase analytics you want to have at least one comment on every MR - otherwise the system will start to think you're falling behind... I hate codebase analytics.
Analytics software like that has made my professional life so annoying at many times.
In my experience, the managers get confused when issues/PRs are closed without any comment.
Useless comments beat having them pop into your slack to ask "hey, did you review this?" with a link to an approved PR.