Trump's actions are often just attempts to satisfy his ego through positive media and supporter reaction. The issue with Iran if you recall is that his main supporter at the time, Fox news had a mixed reaction, with Tucker Carlson being extremely critical, something obviously like hell freezing over.

You can go and check back on the entire Carlson arc back then but here for example Fox's Tucker Carlson slammed conservatives for pushing Trump to go to war: 'About 20 minutes ago we were denouncing these very people as the deep state'

His base didn't particularly like that idea, he was MAGA and isolationist and yet he was about to put the US into a war with a nobody-country that wasn't a threat at the time. It wasn't Bush post 9/11 even though he thought that was an easy win.

As soon as the base consolidated into the neutral/negative camp which he didn't expect, he backed off. Right now his base is very much positive towards ending "Biden's war" so he is very likely to do it.

But his base also doesn't like China so that will be the next target.

At the very least, you can still argue that Trump was duped by his advisors into thinking that assassinating a “rogue general” can solve the Iran problem.

Thing is, if that's the case he can probably be duped again.

After Soleimani was killed and a war was nearly started with Iran in January 2020, there was still an “oh shit” moment from the Trump government and they quickly walked back and prevented a war from being escalated.

Is that because he's genuinely anti-war or cuz some Brass at the Pentagon thought it wasn't an opportune time to start shit with Iran and told him to cool it?

Really at the end of the day I don't think it matters, the PSL could win this Presidential race and it wouldn't change a thing foreign policy wise (and probably not much domestically either), those aren't decisions any elected leader has any meaningful sway over.

After Soleimani was killed and a war was nearly started with Iran in January 2020, there was still an “oh shit” moment from the Trump government and they quickly walked back and prevented a war from being escalated.

You got the order wrong, they first backed off from war around september 2019, and then assassinated Soleimani as a last word and consolation prize for hawks. The actual reason they backed off was that Iran demonstrated both will and ability to defend itself by series of force shows and shooting down the best US drone with old Soviet missile - which also shown pentagon bonzos that the war might be way harder than they though.