threedragons_19

joined 1 year ago
[โ€“] [email protected] 2 points 1 year ago

Didn't even realise this had happened, I always liked that pub! Classic Wolverhampton though, there is a history of 'Accidental' fires...

 

Hello again, I'm in a situation where the one the senior devs on my team just isn't following best practices we laid out in our internal documentation, nor the generally agreed best practices for react; his code works mind you, but as a a team working on a client piece I'm not super comfortable with something so fragile being passed to the client.

He also doesn't like unit testing and only includes minimal smoke tests, often times he writes his components in ways that will break existing unit tests (there is a caveat that one of the components which is breaking is super fragile; he also led the creation of that one.) But then leaves me to fix it during PR approval.

It's weird because I literally went through most of the same training in company with him on best practices and TDD, but he just seems to ignore it.

I'm not super comfortable approving his work, but its functional and I don't want to hold up sprints,but I'm keenly aware that it could make things really messy whenbwe leave and the client begins to handle it on their own.

What are y'alls thoughts on this, is this sort of thing common?

[โ€“] [email protected] 1 points 1 year ago

Yeah I've definitely had situations where its been useful, lime double checking safety critical algorithms or making sure I haven't missed anything obvious. But a lot of the time in my current team it just ends up feeling redundant, especially since it's a small dev team.

 

I've been working in programming for a few years and I think I really dislike Pair Programming; I understand how it is but I often find it mind-numbingly dull. I have a feeling I'm doing it wrong but I feel like as a part of a dev team tasks should be broken into discrete enough chunks that a single person can just blitz through the work... Maybe it's just me, what are y'all thoughts on the matter?