5
submitted 2 years ago by [email protected] to c/[email protected]

Did I break a taboo by doing this?

top 10 comments
sorted by: hot top new old
[-] [email protected] 3 points 2 years ago

I would rename Check to Must which there is at least some precedent for.

[-] [email protected] 1 points 2 years ago* (last edited 2 years ago)

Oh yeah and it's also less to type. Good idea!

Edit: here's the change https://github.com/danhab99/idk/blob/main/idk.go#L13

[-] [email protected] 3 points 2 years ago

I don’t think it is a taboo, but it is possibly just worse code in many cases. Handling error values is usually something that should be done thoughtfully. Panic is nice but can easily be overused and should not make it out of a package.

I too wish there was a better way, but in the form of proper enums and result and option types. However, wrapping in functions is fine in some cases not taboo.

As an aside, you probably don’t need a static union type for your min and max functions. I assume you could use comparable.

[-] [email protected] 2 points 2 years ago

As an aside, you probably don’t need a static union type for your min and max functions. I assume you could use comparable.

comparible only allows ==

[-] [email protected] 2 points 2 years ago

Oh right! What am I saying? contraints.Ordered maybe.

[-] [email protected] 1 points 2 years ago

I just looked at the standard docs and I didn't realize there was a built-in min and max function. Y'all should really read the standard lib docs.. it's fascinating in there.

[-] [email protected] 3 points 2 years ago

There is! See “Errors are values” from the Go blog: https://go.dev/blog/errors-are-values

[-] [email protected] 0 points 2 years ago

Yeah I know about that article.... Then again... I'm lazy

[-] [email protected] 2 points 2 years ago

I would call it a taboo because it diverges from the general best practice. That makes your code harder to read and understand for people less familiar with "your style". Given that code is read much more often that it is written, you are optimizing on the wrong end.

[-] [email protected] -4 points 2 years ago

I too consider that if err != nil a bit complicated to type. Most times, I wrap it away in a function like your Check0. I know that the major "framework" for command line applications (cobra) has a similar logic with its checkError function.

this post was submitted on 25 Sep 2023
5 points (64.7% liked)

Golang

2485 readers
4 users here now

This is a community dedicated to the go programming language.

Useful Links:

Rules:

founded 2 years ago
MODERATORS