8
replacing mlmym with a fork (code.mschae23.de)
submitted 3 months ago by to c/lemmytoday@lemmy.today
32 comments fedilink hide all child comments
 

hello. i'm a happy user of lemmy.today.

i've always used the mlmym frontend available on old.lemmy.today, it generally works well enough. however, there are some minor minor bugs and missing features. (e.g. impossible to navigate to next page when viewing saved posts, impossible to see down/upvotes separated)

i recently came across this fork of mlmym (from this github issue) and it seems to have all those bugs fixed. can we replace the current mlmym with this fork?

thanks for reading

you are viewing a single comment's thread
view the rest of the comments
[–] 2 points 2 months ago* (last edited 2 months ago) (2 children)

Yes, let's do it.

And sorry for the late response, I didn't see this post until I got a private message about it.

Will try and get it up today.

Edit: And its up. I enabled the SHOW_UNREAD_COMMENTS option as well.

  • permalink
  • fedilink
  • source
  • hideshow 4 child comments
    •
  • [–] 2 points 2 months ago (1 child)

    Oh, while you're here, I think LANGUAGE_TAGS is also a good candidate to turn on by default (forgot to add it to the readme when I added the feature, so I also forgot about it in my earlier message...), and maybe SHOW_CONTROVERSIAL.

    There's also EMBED_METADATA for embeds (for links on Discord and such) to show, but I don't know if you want that.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 2 child comments
    •
  • [–] [S] 2 points 2 months ago* (1 child)

    thanks a lot! it seems to work well :)

    edit: for some reason the communities bar on the top doesn't seem to work properly :( before there was a list of all subscripbed communities, now it's blank..

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 2 child comments
    •
  • [–] 2 points 2 months ago (2 children)

    Hmm, that's not good... Could be a bug in this version perhaps... Will have to roll back if I can't fix it somehow.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 4 child comments
    •
  • [–] [S] 3 points 2 months ago (2 children)

    i tried compiling it locally and there's the same issue. however it seems to appear in certain conditions but disappear again on a refresh..

    now that we've rolled back, i'll let you know again if this bug gets solved.

    thanks a lot

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 4 child comments
    •
  • [–] 2 points 2 months ago (1 child)

    Perhaps it works now for you. I made some changes to the networking that was causing it to run slow, perhaps that also created your issues. If you hold shift and click reload in the browser to skip the browser cache, perhaps that will also work.

    Is it the top bar in this picture you dont see?

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 2 child comments
    •
  • [–] [S] 2 points 2 months ago* (1 child)

    yes, the top bar (technology lemmyshitpost memes me_irl ...). it seems be working now for some reason, thanks

    edit: hmm now comment scores aren't showing lmao. maybe there's something wrong with my browser?... seems like something's buggy...

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 2 child comments
    •
  • [–] 1 point 2 months ago* (1 child)

    hmm now comment scores aren't showing lmao. maybe there's something wrong with my browser?... seems like something's buggy...

    That looks like you have “show scores” disabled in the preferences? Can't think of any other reason they wouldn't be showing like this.

    Also, if you're wondering about the “also show on comments” option for upvote/downvote totals, I found that too distracting to show on every comment, so that extra information is only shown when there are actually both upvotes and downvotes.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 2 child comments
    •
  • [–] [S] 2 points 2 months ago* (2 children)

    That looks like you have “show scores” disabled in the preferences? Can't think of any other reason they wouldn't be showing like this.

    "show scores" was already enabled, but disabling -> saving -> enabling fixed it, i guess the settings for my account was in a weird state. it's all resolved now, thanks!

    ok seems like i said that too early, the top bar disappearing issue came back, lol. it seems to work a few times randomly.. it isn't a critical bug so i'll keep using and investigating.

    the 'my communities' button always seems to work

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 4 child comments
    •
  • [–] 1 point 2 months ago (1 child)

    You said it only appears sometimes and it fixes itself on refreshes, right? I think that would rule out a mistake in the templates somewhere (which would've meant that it's consistently failing on some pages).

    I wonder what the HTML output looks like when you can reproduce it. Do the <a> elements for the links not get output at all (more likely) or are they hidden somehow?

    I'm not really sure on why this would happen, to be honest.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 2 child comments
    •
  • [–] [S] 2 points 1 month ago* (1 child)

    ok it's been a month, i now realized why scores don't show..

    i use 'always private mode' in firefox, so my cookies get wiped on each and every session

    cookies on this website isn't getting set when i just visit the main page (old.lemmy.today), i need to visit the settings page (old.lemmy.today/settings). just visiting settings once sets all the cookies and i'm good for that session..

    i don't know programming properly but it seems like cookie setting code is only in here (settings), perhaps it should be added to other pages too?

    still haven't figured out the top bar being empty in most cases tho..

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 2 child comments
    •
  • [–] 2 points 1 month ago (1 child)

    i use 'always private mode' in firefox, so my cookies get wiped on each and every session

    Oh, I see. I was able to reproduce the issue now.

    cookies on this website isn't getting set when i just visit the main page (old.lemmy.today), i need to visit the settings page (old.lemmy.today/settings). just visiting settings once sets all the cookies and i'm good for that session..

    i don't know programming properly but it seems like cookie setting code is only in here (settings), perhaps it should be added to other pages too?

    The settings cookies are also supposed to be set when visiting the frontpage for the first time, but for some reason, only CookieAge is being set (maybe the GetSite call fails? figured it out. It was because CookieAge is also set when logged out, which is the reason the settings cookies weren't refreshed when loading the frontpage). But I just made it set these cookies on login, which I think is a good idea anyway.

    The reason you only noticed this with scores is that the “show scores” setting is one of only a few that doesn't have an environment variable, so unlike most other settings, it thinks it's disabled rather than using the default when the cookie is missing. The same doesn't happen when logged out because the setting is just force-enabled in that case.

    I just released version 26.3.1 that fixes this bug.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 2 child comments
    •
  • [–] [S] 2 points 1 month ago (1 child)

    thanks a lot for the quick fix!

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 2 child comments
    •
  • [–] 1 point 1 month ago (1 child)

    still haven't figured out the top bar being empty in most cases tho..

    Do you happen to have set your listing type to local in the preferences? (“show posts from [local] communities by default”)

    I was made aware of an issue with that today – basically, non-local communities are filtered out from the list when that is set, but the list only includes the top twenty communities in the first place, so it just ends up empty. Version 26.3.3 should fix this :)

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 2 child comments
    •
  • [–] 1 point 2 months ago*

    Try to hold shift and reload the entire old.lemmy.today site in the browser. It's possible the old mlmym and this new one are conflicting somehow.

    I also changed a lot of stuff with networking for it, so it's faster now I think.

    If you still have problems, try a different browser just to see if it works there. Then we know it's a browser issue if it does.

  • permalink
  • fedilink
  • source
  • parent
  • [–] 1 point 2 months ago (1 child)

    Hm, it's working on my instance. I did change it to only make the search request for top communities once and cache it, so maybe that happened to run into an error and it's not trying again?

    Running it locally on lemmy.today, it does seem to be working. I don't have an account here, unfortunately, so I can't test whether the “my communities” dropdown works too, but I don't see why it shouldn't.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 2 child comments
    •