8
replacing mlmym with a fork (code.mschae23.de)
submitted 3 months ago by to c/lemmytoday@lemmy.today
32 comments fedilink hide all child comments
 

hello. i'm a happy user of lemmy.today.

i've always used the mlmym frontend available on old.lemmy.today, it generally works well enough. however, there are some minor minor bugs and missing features. (e.g. impossible to navigate to next page when viewing saved posts, impossible to see down/upvotes separated)

i recently came across this fork of mlmym (from this github issue) and it seems to have all those bugs fixed. can we replace the current mlmym with this fork?

thanks for reading

you are viewing a single comment's thread
view the rest of the comments
[–] 1 point 2 months ago (1 child)

You said it only appears sometimes and it fixes itself on refreshes, right? I think that would rule out a mistake in the templates somewhere (which would've meant that it's consistently failing on some pages).

I wonder what the HTML output looks like when you can reproduce it. Do the <a> elements for the links not get output at all (more likely) or are they hidden somehow?

I'm not really sure on why this would happen, to be honest.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 2 child comments
    •
  • [–] [S] 2 points 1 month ago* (1 child)

    ok it's been a month, i now realized why scores don't show..

    i use 'always private mode' in firefox, so my cookies get wiped on each and every session

    cookies on this website isn't getting set when i just visit the main page (old.lemmy.today), i need to visit the settings page (old.lemmy.today/settings). just visiting settings once sets all the cookies and i'm good for that session..

    i don't know programming properly but it seems like cookie setting code is only in here (settings), perhaps it should be added to other pages too?

    still haven't figured out the top bar being empty in most cases tho..

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 2 child comments
    •
  • [–] 2 points 1 month ago (1 child)

    i use 'always private mode' in firefox, so my cookies get wiped on each and every session

    Oh, I see. I was able to reproduce the issue now.

    cookies on this website isn't getting set when i just visit the main page (old.lemmy.today), i need to visit the settings page (old.lemmy.today/settings). just visiting settings once sets all the cookies and i'm good for that session..

    i don't know programming properly but it seems like cookie setting code is only in here (settings), perhaps it should be added to other pages too?

    The settings cookies are also supposed to be set when visiting the frontpage for the first time, but for some reason, only CookieAge is being set (maybe the GetSite call fails? figured it out. It was because CookieAge is also set when logged out, which is the reason the settings cookies weren't refreshed when loading the frontpage). But I just made it set these cookies on login, which I think is a good idea anyway.

    The reason you only noticed this with scores is that the “show scores” setting is one of only a few that doesn't have an environment variable, so unlike most other settings, it thinks it's disabled rather than using the default when the cookie is missing. The same doesn't happen when logged out because the setting is just force-enabled in that case.

    I just released version 26.3.1 that fixes this bug.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 2 child comments
    •
  • [–] [S] 2 points 1 month ago (1 child)

    thanks a lot for the quick fix!

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 2 child comments
    •
  • [–] 1 point 1 month ago (1 child)

    still haven't figured out the top bar being empty in most cases tho..

    Do you happen to have set your listing type to local in the preferences? (“show posts from [local] communities by default”)

    I was made aware of an issue with that today – basically, non-local communities are filtered out from the list when that is set, but the list only includes the top twenty communities in the first place, so it just ends up empty. Version 26.3.3 should fix this :)

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 2 child comments
    •