32
Mistakes I see engineers making in their code reviews
(www.seangoedecke.com)
you are viewing a single comment's thread
view the rest of the comments
view the rest of the comments
this post was submitted on 26 Oct 2025
32 points (100.0% liked)
Programming
25440 readers
393 users here now
Welcome to the main community in programming.dev! Feel free to post anything relating to programming here!
Cross posting is strongly encouraged in the instance. If you feel your post or another person's post makes sense in another community cross post into it.
Hope you enjoy the instance!
Rules
Rules
- Follow the programming.dev instance rules
- Keep content related to programming in some way
- If you're posting long videos try to add in some form of tldr for those who don't want to watch videos
Wormhole
Follow the wormhole through a path of communities !webdev@programming.dev
founded 2 years ago
MODERATORS
Good, I just partially disagree with the 5-6 comments per PR. The number of comments is usually proportional to the number of changes. 10 comments in a 300-line PR seems excessive. 20 comments for 5k lines doesn't.
Sure I can just shrug it and say I'm not reviewing a 10k line PR until it's split, but that's not very helpful either. So I just leave more comments and if they think it's too much, I'd encourage them to open a smaller PR next time.
Is it? I feel there’s some threshold where a big enough change sails through unimpeded if the requester is sufficiently liked.