this post was submitted on 17 Aug 2023
19 points (100.0% liked)

flashlight

2946 readers
2 users here now

Portable illumination

Rules:

  1. Be excellent to each other
  2. Don't be the reason we need to make more rules

Related:

founded 1 year ago
MODERATORS
 

Hi Anduril user's !

I noticed that the momentary turbo does not work for 4H from the "ON" state (3H for those who do not have tint ramping).

To fix it, I have to comment out line 423:

if (! arg) { // first frame only, to allow thermal regulation to work

[https://bazaar.launchpad.net/~toykeeper/flashlight-firmware/multi-channel/view/head:/ToyKeeper/spaghetti-monster/anduril/ramp-mode.c#L423

Do you have the same behavior?

Thank you and good day

you are viewing a single comment's thread
view the rest of the comments
[–] [email protected] 1 points 1 year ago

That makes sense that it’s easier to flash directly since there are so many different parts and variations to the actual destination hardware.

I read that one of Toykeeper’s original design decisions was to separate out the generic UI code from the specific code that interfaces with the hardware (being vague due to lack of knowledge). Maybe it would be possible to incorporate some testing code that only evaluates the user inputs compared to expected outputs within the Anduril layer? Such as a single state transition like “when multi-channel is enabled and user selects 4H, selected output level is equal to turbo”. Such a test could be indicate unexpected behavior when UI code is being customized.

Just adding to the imaginary backlog here!