Programmer Humor

32042 readers

930 users here now

Post funny things about programming here! (Or just rant about your favourite programming language.)

Rules:

Posts must be relevant to programming, programmers, or computer science.
No NSFW content.
Jokes must be in good taste. No hate speech, bigotry, etc.

founded 5 years ago

MODERATORS

[email protected]

701

Better start fixing your spaghetti code. (lemmy.world)

submitted 3 weeks ago by [email protected] to c/[email protected]

18 comments fedilink hide all child comments

you are viewing a single comment's thread
view the rest of the comments

[–] [email protected] 10 points 2 weeks ago (1 children)

Can you simply ask them to walk through their submission line by line with you, explaining what it's doing?

This. Code reviews, especially with junior devs, should always be done as a conversation. It's an opportunity to learn (from both sides), not just a a bunch of "bad implementation. rewrite" thrown in the PR.

[–] [email protected] 6 points 2 weeks ago* (last edited 2 weeks ago)

Completely agree! It's SO much easier to lighten the mood and keep things upbeat and productive in an actual conversation vs. just text-based feedback. For example it makes it easy to throw in self-deprecating anecdotes of your own when discussing mistakes / needed changes, which can really help put juniors at ease. It's just worlds better in >90% of scenarios.