this post was submitted on 06 Jul 2024
448 points (95.5% liked)

Programmer Humor

32725 readers
64 users here now

Post funny things about programming here! (Or just rant about your favourite programming language.)

Rules:

founded 5 years ago
MODERATORS
 
you are viewing a single comment's thread
view the rest of the comments
[–] [email protected] 17 points 5 months ago (2 children)

Refactoring is often necessary to ensure new features can be continuously added with ease.

[–] [email protected] 6 points 5 months ago* (last edited 5 months ago)

Yes, and you do it at the point you need to work on that feature. The business pay for it when they want the change.

You do not pay for the refactor with your time, if the company won't pay to fix their code. Just make it clear the risks and how bad it could be if you carry on with duct tape fixes.

You have to be strong and firm and not agree to hacks. You need to work with your team to ensure you're on the same page rather than getting undermined by cowboy dev claiming he can do the feature in 2 days when it needs 2 weeks to do the necessary work.

[–] [email protected] 2 points 5 months ago (2 children)

Sure, refactoring is sometimes necessary. But refactoring also introduces new bugs often. Our code base is constantly being refactoring, and it's not more reliable, stuff is constantly breaking.

[–] [email protected] 5 points 5 months ago (1 children)

Tell me that you don't have a test suite without telling you don't have a test suite

[–] [email protected] -3 points 5 months ago (2 children)

Why are programmers so arrogant? They do have unit tests, and a dedicated test team. Refactoring can and does introduce bugs. It's a fact.

[–] [email protected] 3 points 5 months ago

Frankly, if your test suite isn't catching 95% or more of the bugs, there's a problem with the test suite and if uat aren't catching 95% or more of the remainder, there's a problem with uat

[–] [email protected] 2 points 5 months ago (1 children)

How solid is the unit test coverage? What about regression tests? If you get new bugs creeping in all the time, your bug-catchers aren't doing their job

[–] [email protected] 2 points 5 months ago* (last edited 5 months ago) (1 children)

Yeah, I've said that before. I don't think they have enough regression tests, and unit tests.

[–] [email protected] 2 points 5 months ago

I did a sting writing tests for a team that previously had none. Fun times, the things that were uncovered that day...

[–] [email protected] 4 points 5 months ago

Refactoring for the sake of refactoring is rarely a good thing. It should be done with a clear purpose in mind.