774
Peer reviewing is torture now (thelemmy.club)
submitted 19 hours ago by to c/programmer_humor@programming.dev
110 comments fedilink hide all child comments
 
you are viewing a single comment's thread
view the rest of the comments
[–] 88 points 18 hours ago (13 children)

I struggle to review a 1k line change. When people give me such big changes I normally don't believe they've reviewed them either.

  • permalink
  • fedilink
  • source
  • hideshow 13 child comments
    •
  • [–] 13 points 15 hours ago (3 children)

    Try working on a codebase that's all event-driven hexagonal CQRS with hand-crafted SQL for persistence. Add additional buzzwordy methodologies to taste.

    Adding a single property to your product means you now have to update an aggregate class, several DTOs, and several event classes and handlers before you can even think about touching the UI.

    And that's in your main solution. There's also at least one facade service you'll need to make compatible and you also need to update the event simulator used for testing. The latter night involve having to touch every single line in a 2000 lines long SQL script.

    Having to go though three separate 600-2000 LOC PRs for one PBI isn't that exotic.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 3 child comments
    •
  • [–] 6 points 16 hours ago (6 children)

    Occasionally I do that…but only because 500 of those lines are my comments explaining everything.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 6 child comments
    •
  • [–] 3 points 6 hours ago* (last edited 6 hours ago) (5 children)

    Please don't explain that much, make your code easier to understand.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 5 child comments
    •
  • [–] 2 points 3 hours ago* (4 children)

    I’m aware. Not always feasible. For example, had to add a custom video capture solution that captures the last 30 seconds of a process for crash handling purposes.

    You most definitely need to do add that much comments explaining the mp4 box format along with the box “hierarchy” of what is being written. Add to that MFT (h264 encode) code…

    Basically, if anything, the comments are for me for when I look back at that code.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 4 child comments
    •
  • [–] 1 point 2 hours ago (3 children)

    had to add a custom video capture solution that captures the last 30 seconds of a process for crash handling purposes.

    Commanded from above? This smells like a noob idea.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 3 child comments
    •
  • [–] 1 point 2 hours ago (2 children)

    I have no idea what your response even means/is getting at.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 2 child comments
    •
  • [–] 1 point 1 hour ago (1 child)

    This is my attempt to translate: You had to add a feature like that ? Must have been an order from your boss. That seems like a feature someone rather inexperienced and unknowledgeable would request.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 1 child comment
    •
  • [–] 2 points 1 hour ago
    1. Legal has issues with using existing libraries (including MIT). Definitely idiotic, but I can’t control that.
    2. Idea was mine.
    3. Subprocess that captures parent process active video with a rolling buffer for crash handling purposes is absolutely necessary when trying to reproduce issues in development (Gamedev editor). If you think associating the last 15s prior to a crash with a mindump isn’t helpful for debugging, I don’t know what to tell you.
  • permalink
  • fedilink
  • source
  • parent