844
Peer reviewing is torture now (thelemmy.club)
submitted 1 day ago by to c/programmer_humor@programming.dev
124 comments fedilink hide all child comments
 
you are viewing a single comment's thread
view the rest of the comments
[–] 6 points 21 hours ago (6 children)

Occasionally I do that…but only because 500 of those lines are my comments explaining everything.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 6 child comments
    •
  • [–] 4 points 11 hours ago* (last edited 11 hours ago) (5 children)

    Please don't explain that much, make your code easier to understand.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 5 child comments
    •
  • [–] 3 points 8 hours ago* (4 children)

    I’m aware. Not always feasible. For example, had to add a custom video capture solution that captures the last 30 seconds of a process for crash handling purposes.

    You most definitely need to do add that much comments explaining the mp4 box format along with the box “hierarchy” of what is being written. Add to that MFT (h264 encode) code…

    Basically, if anything, the comments are for me for when I look back at that code.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 4 child comments
    •
  • [–] 1 point 7 hours ago (3 children)

    had to add a custom video capture solution that captures the last 30 seconds of a process for crash handling purposes.

    Commanded from above? This smells like a noob idea.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 3 child comments
    •
  • [–] 1 point 7 hours ago (2 children)

    I have no idea what your response even means/is getting at.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 2 child comments
    •
  • [–] 1 point 6 hours ago (1 child)

    This is my attempt to translate: You had to add a feature like that ? Must have been an order from your boss. That seems like a feature someone rather inexperienced and unknowledgeable would request.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 1 child comment
    •
  • [–] 4 points 6 hours ago
    1. Legal has issues with using existing libraries (including MIT). Definitely idiotic, but I can’t control that.
    2. Idea was mine.
    3. Subprocess that captures parent process active video with a rolling buffer for crash handling purposes is absolutely necessary when trying to reproduce issues in development (Gamedev editor). If you think associating the last 15s prior to a crash with a mindump isn’t helpful for debugging, I don’t know what to tell you.
  • permalink
  • fedilink
  • source
  • parent