586
GitHub - LadybirdBrowser/ladybird: Truly independent web browser (github.com)
submitted 2 years ago by to c/technology@lemmy.world
183 comments fedilink hide all child comments
you are viewing a single comment's thread
view the rest of the comments
[–] 7 points 2 years ago* (1 child)

True, but that only applies if it's misleading. For example:

// pythagoran theorem 
distance = abs(p2.x - p1.x) + abs(p2.y - p1.y);

Fixing that makes sense because it's wrong and misleading (it's actually Manhattan distance), and a quick glace is insufficient to tell the difference.

But fixing a typo or something that wouldn't be confusing is just noise and should only be fixed with other changes. For example, I intentionally misspelled Pythagorean in my comment above, fixing that to be the right spelling would be a useless change, even if the distance formula used the hypotenuse. It wouldn't be an unreasonable policy to reject PRs that only fix spelling or similar to reduce noise for the maintainers.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 2 child comments
    •
  • [–] 4 points 2 years ago (1 child)

    Yep, I understand but disagree. Maybe it comes from working with so many ESL coders, but I'll happily accept typo corrections because it's not always obvious what words should be if you're not steeped in the culture.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 2 child comments
    •
  • [–] 4 points 2 years ago* (1 child)

    It really depends on the project.

    If you're a larger project, you can see a ton of these from people hoping to land a commit to put "contributor to X" on a resume somewhere. Those add up and are really distracting and possibly automated. They waste everyone's time, especially if they spawn a bunch of conversion like this did.

    If you're a smaller project, it doesn't matter as much. I work with ESL coders too, so I get it (1/4 of my office is ESL immigrants, and ~2/3 of the broader team is ESL). I fix comments all the time, I just include them with other changes.

    So it depends. But in general, a high profile project should reject this noise to discourage this behavior.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 2 child comments
    •
  • [–] 4 points 2 years ago (1 child)

    In theory that's fair reasoning. Unfortunately the dev made it clear that his reasoning was based on politics

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 2 child comments
    •
  • [–] 1 point 2 years ago

    Did he? I only saw him point to the rule against politics.

    He should have said it's because the PR isn't worth the time, but it also seems motivated by something that's against the rules (i.e. why make a PR that only fixes gender in one comment? There was a later PR that was accepted that fixed it in several places).

    So without more evidence, I cannot say what the dev's motivations for rejecting the PR were, aside from the apparent rule breakage mentioned. They didn't say they disagreed with the change (i.e. that the change was wrong), just the proposal of the change (i.e. seems more motivated by virtue signaling instead of improving the dev experience). And you can look at the comments and see justification for that position, since it quickly devolved into actual politics with people accusing the dev of being a Nazi.

    Maybe if you showed a pattern across more than just this incident (i.e. over months or years), but this sounds more like people being stubborn than tolerant.

  • permalink
  • fedilink
  • source
  • parent