I started out using LastPass because it's what work used which was obviously a bad idea. When it came time to leave them I moved to bitwarden which has been pretty fantastic but I mainly use it because I need to share passwords amongst my family and I really like the TOTP integration.

If I didn't have that need I would probably use KeypassX and throw it's database into a Dropbox or Syncthing.