I think the main thing here is the timing and context
The fork became into existence during the split in Piefed community around May (IYKYK). I think that the way you played out this incorporation of the code might have felt as erasure of contribution. It's not about the code or licenses. It's about how we treat each other. As far as I read the room, the fork became because of what was happening, not because of having a different vision. It came into existence, so those who could no longer type in Matrix support channels could still affect how the software they are running behaves. And then the mainline, they were (socially-wise) barred from influencing, copied some of their changes. And some with another author on the commit.
PyLova being a fork, you could have cherry-picked the commits. It keeps original authors. The first copy via a patch that kept attribution was better.
With the stuff going on in the background you could have asked in an issue if they are ok with you taking these parts. Legally they probably couldn't say no, but people-wise sometimes the point is if someone asks.
You also could have mentioned them in commit message.
Without that context, I think just copying the code would be ok. As far as my understanding goes, it is one of the core ideas behind open-source that improvements are not gate-kept behind the will of the one doing the improvement to share or not. Maybe a mention in the merge commit message or the first commit of the copy would be a polite thing to do.
But with the context of what was happening in the background, I think it might have felt first as "you go play away from us, you're on your own, good luck" and then "oh, good idea. I'm gonna present it as my own"
Again, my take is about feelings and participating in communities. Not laws and licenses
all 15 comments