197
Fun fact: you can't upload this image on piefed.social (thelemmy.club)
submitted 7 months ago by to c/fediverse@lemmy.world
166 comments fedilink hide all child comments
 

https://codeberg.org/rimu/pyfedi/src/commit/6405e51dab23f43eaea18d0ee4d9e7a773a3fd31/app/community/forms.py#L335

deliberately misleading error message.

a white background with the words "anonymous" and "no.676767" on it in black Arial font
you are viewing a single comment's thread
view the rest of the comments
[–] 73 points 7 months ago* (12 children)

lol hardcoded shit everywhere. that codebase is so bad it's entertaining. you should make a standalone post about this here and crosspost to !programming_horror@programming.dev

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 12 child comments
    •
  • [+] -20 points 7 months ago* (last edited 7 months ago) (11 children)

    lol hardcoded shit everywhere

    It's open source. Why not? People who want a configuration menu can create a patch.

    Downvoters, do you have an argument? What is it but entitlement to demand that free open source software should be written differently from what the programmer wants?

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 11 child comments
    •
  • [–] 34 points 7 months ago (3 children)

    Just because code is open source doesn't mean shit code can't be called out. Shit code is shit code.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 3 child comments
    •
  • [+] -9 points 7 months ago (2 children)

    But why is hardcoding shit code for open source code? The code is easier to read because no if or switch statements are needed to distinguish between the options. No configiration menu has to be maintained.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 2 child comments
    •
  • [–] 12 points 7 months ago*

    Open source just means people are free to edit it and distribute their changes. Hardcoding things like this is bad practice no matter if it’s open source or not. It’s not maintainable. Maintainable as in easily maintainable, I.e., configuration files not code edits.

  • permalink
  • fedilink
  • source
  • parent
  • [–] 5 points 7 months ago

    That if chain is horrendous. You should have a config json file with an array of links and then use a for and check for each of them.

    The advantage of having a config file is that it's easily for others to see everything that can be changed dynamically without touching the code, and it's much easier to maintain forks that change or extend the configurable behaviour.

    Hard coding shit is bad because it's actually harder to maintain. No programmer worth their salt has difficulty checking the json file that has the configuration for X list, hard coding an if chain is bad coding.

  • permalink
  • fedilink
  • source
  • parent
  • [–] 31 points 7 months ago (5 children)

    I didn't downvote your comment. But let me argue anyway.

    Lots of people flock to PieFed because it is not made by the Lenmy devs who are unpalatably heavy handed in their "moderation" on the ml instance. One would hope this means PieFed offers more freedom to use the software how you like. So it's funny that it's even stricter "moderation" AND NOW ITS HARDCODED so it affects every instance.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 5 child comments
    •
  • [–] 10 points 7 months ago

    So it’s funny that it’s even stricter “moderation” AND NOW ITS HARDCODED so it affects every instance.

    Lol, people so afraid of Lemmy devs bowing to the CCP that they migrate to the fediverse option that actually implements CCP societal control features. McCarthysim really did a number on the Amerikkkan brain, dunno if it is impacting people from elsewhere that much. This surely was not in my 2026 Bingo card!

  • permalink
  • fedilink
  • source
  • parent
  • [–] -3 points 7 months ago (3 children)

    ITS HARDCODED so it affects every instance.

    It's open source. Every instance can change it and if something is common, people can maintain the patch together.

    Lenmy devs who are unpalatably heavy handed in their “moderation” on the ml instance.

    Which is their instance. I don't like the hate they receive. They have established a social network that allows everybody to run their own instance with their own moderation. To present them as the villains must be nurtured by the establishment.

    So it’s funny that it’s even stricter

    Absolutely

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 3 child comments
    •
  • [–] 14 points 7 months ago (2 children)

    That isn’t how it works. They would have to FORK the code and maintain their changes going forward with every update. That is poor software development practices no matter how you look at it.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 2 child comments
    •
  • [–] -3 points 7 months ago (1 child)

    I think the Brave browser does it with Chrome. Wouldn't the source control tool do most of the maintenance?

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 1 child comment
    •
  • [–] 9 points 7 months ago*

    Chromium is a well-organized and mature codebase, which makes syncing changes relatively easy (also Brave's chageset is limited in scope, so less conflicts to worry about). PieFed is neither mature nor well-organized. Maintaining a downstream project from it would be a nightmare.

  • permalink
  • fedilink
  • source
  • parent