380
Permanently Deleted (lemmy.world)
submitted 8 months ago* (last edited 8 months ago) by to c/memes@lemmy.world
146 comments fedilink hide all child comments
 

Permanently Deleted

you are viewing a single comment's thread
view the rest of the comments
[–] 60 points 8 months ago (11 children)

Jesus that's a lot of spaghetti code, and why are they hardcoding a bunch of terms? Is this just for a public facing site, or does every deployed instance effectively filter these out?

  • permalink
  • fedilink
  • source
  • hideshow 11 child comments
    •
  • [–] [S] 77 points 8 months ago* (last edited 8 months ago) (8 children)

    It's hardcoded in the PieFed source code, so every instance does this by default unless you patch it like I did.

    The combined swearwords + excluded communities list seems to appear at least 3 times in the codebase (not referenced, copied verbatim).

    Let's just say that it wouldn't pass my code review if I saw this at work

    EDIT: It has been removed from 2/3 places in the codebase.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 8 child comments
    •
  • [–] 11 points 8 months ago (4 children)

    The piefed.world instance has some of these edited out but I don’t think they all are.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 4 child comments
    •
  • [–] [S] 4 points 8 months ago (3 children)

    I think the communities were added manually

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 3 child comments
    •
  • [–] 2 points 8 months ago (2 children)

    How do you manually add communities?

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 2 child comments
    •
  • [–] 3 points 8 months ago

    You just try to go to the community from that instance, and it'll say "community not found" and you just click it. Then someone local needs to subscribe to it for new content from there to federate.

  • permalink
  • fedilink
  • source
  • parent
  • [–] 12 points 8 months ago (1 child)

    Yeah. The list should be in the site config. Go ahead and include those as defaults to block, but allow sites to override that.

    OP, are you saying that the federation is blocked on the OUTGOING side? Because then that just seems bass ackwards.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 1 child comment
    •
  • [–] [S] 9 points 8 months ago

    No, it's incoming. When you first set up an instance you have to kickstart the federation process by adding communities to federate. The linked code excludes those specified communities from that. Once federated, they won't be blocked AFAIK.

  • permalink
  • fedilink
  • source
  • parent