808
Don't touch my garbage! (feddit.org)
submitted 10 months ago* (last edited 10 months ago) by to c/programmer_humor@programming.dev
52 comments fedilink hide all child comments
 

Edit: Thanks for your kind comments on disabling contributions. I'm aware of the possibility, this is just a meme.

Contributions in open source projects are great, needed and make the world a better place after all. Therefore they should be declined politely, optionally by giving a reason.

I hereby inform you that I will no longer accept contributions to this post /s.

you are viewing a single comment's thread
view the rest of the comments
[–] 19 points 10 months ago* (last edited 10 months ago) (20 children)

I never understand people rejecting free improvements on FOSS projects.

EDIT: Y'all, It's not like I cannot comprehend why they do it. Please stop trying to explain it to me. When I said "I don't understand", I meant the psyche of the character that does that. I personally do FOSS to improve the world and collaborate with others that do so as well. I will never get people who do FOSS and then get salty about people liking it too much.

  • permalink
  • fedilink
  • source
  • hideshow 20 child comments
    •
  • [–] [S] 103 points 10 months ago (2 children)

    Apart from bad quality code, the PR might not fit the vision the owner has in mind for the project. Improvements are subjective.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 2 child comments
    •
  • [+] -9 points 10 months ago (1 child)

    Sure, but that's not what the meme implies.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 1 child comment
    •
  • [–] 56 points 10 months ago

    Verifying that the code doesn't contain regressions, bugs, or vulnerabilities, that it doesn't conflict with whatever the owner is actively developing privately, in addition to making sure it wasn't vomited out by a goddamn clanker, is a huge burden on a solo developer. They are free to decide whether to take on this responsibility.

  • permalink
  • fedilink
  • source
  • parent
  • [–] 58 points 10 months ago (5 children)

    Every bit of code a maintainer accepts becomes their responsibility to maintain. Considering that half the time „improvements” don’t even have tests to help maintaining them, feel free to maintain your own fork.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 5 child comments
    •
  • [–] 0 points 10 months ago* (4 children)

    Sure, one can request those PRs to add those tests before merging.

    Don't get me wrong, I can understand why someone wants to just share without collaborating, but I don't get why they would publish in a collaborative environment, and then make memes about people trying to collaborate with them.

    Personally, as someone writing FOSS for a while now, I'm always happy to get anyone helping out and get demotivated when nobody cares. Being actively hostile to actual code contributors, is just fucking bizarre to me.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 4 child comments
    •
  • [–] 22 points 10 months ago (2 children)

    While I do agree GitHub is a place where people collaborate, it's also a pretty handy place to store stuff without having to host your own. If the project doesn't invite people to contribute, don't expect a polite response forever. It's like stopping your neighbor on the street corner to tell them they should paint their house white for the thermal benefits, yeah people collaborate on the street, yeah you are right, it's their house though.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 2 child comments
    •
  • [–] 5 points 10 months ago (1 child)

    Github provides ways to both display code just as is (archive mode) and to also disable issues and auto-close all PRs with a message.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 1 child comment
    •
  • [–] 4 points 10 months ago

    Is archive mode the appropriate tool for this? I would assume that's for when a repo is no longer receiving any updates from anyone, not just when the owner doesn't want others contributing.

  • permalink
  • fedilink
  • source
  • parent
  • [–] 1 point 10 months ago

    I make my code open source and public so people can use it if they find it useful, not because I expect anyone to contribute.

    And there’s a big fucking difference between actively hostile and “I’m not interested in accepting this change”.

  • permalink
  • fedilink
  • source
  • parent
  • [–] 24 points 10 months ago (2 children)

    Not everything sent in PR is an improvement from everyone pov though. It might be an improvement for the contributor of a new feature they might be the only one to ever use, while it adds maintenance burden for you, more dependencies, risks of bugs etc for the community, which you have to balance somehow. Plus you might have a view on how to do things properly on your project, which needs to be communicated to contributors, which is additional work you might not have time for, especially if this is just some small side project.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 2 child comments
    •
  • [–] 11 points 10 months ago (3 children)

    1. It's meant as a portfolio and I don't want to risk someone mistaking some contribution for my own work.

    2. I don't actually intend to put any time into maintaining it, but you are free to fork it if you want that responsibility.

    3. Your linting is lousy. It causes my eyes much pain.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 3 child comments
    •
  • [–] 6 points 10 months ago

    I never understand people rejecting free improvements on FOSS projects.

    I never understand people who don't install every free FOSS software offered to them on their PC.

    Why would someone take every contribution to their FOSS project? It makes no sense to take a contribution doesn't help the project owner's vision of the project.

  • permalink
  • fedilink
  • source
  • parent
  • [–] 5 points 10 months ago

    I'd probably reject PRs into my FOSS projects, because the aim is to put the code out there for other people to see and do what they want with it. I'm expressing myself, and sharing what I made; I'm not setting up a tentpole project for others to pitch in and take over on, and start managing their contributions and collaborate with them.

    If they want to take the code and do something with it, great. I don't want to be involved in their endeavour.

  • permalink
  • fedilink
  • source
  • parent