136
What is the smallest hill you would die on? (lemmy.dbzer0.com)
submitted 1 year ago by to c/asklemmy@lemmy.ml
356 comments fedilink hide all child comments
you are viewing a single comment's thread
view the rest of the comments
[โ€“] 2 points 1 year ago (1 child)

Why is it better ?

I don't have a strong opinion, taking the style of the team I work with but why do you feel it is better?

It's not like putting it on the other line causes any issue.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 2 child comments
    •
  • [โ€“] 2 points 1 year ago* (last edited 1 year ago) (1 child)

    Both are usable, but I just don't understand why you'd choose the separate line style if you were starting a new codebase. I can't see the benefit of it, but that could also be me not having enough experience with the separate line style to see it's advantages.

    On the other hand, having the brace on the next line means that the parent statement and the code in the braces are further from each other, also more lines in the source file is more scrolling in general. You can fit less lines of code on the same vertical screen height if you have a lot of nested blocks or just generally use a lot of blocks. Especially for things like many small functions or many if blocks, being able to fit a few more on your screen is really convenient IMO.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 2 child comments
    •
  • [โ€“] 2 points 1 year ago

    To me these are just not real concerns. I'm not trying to invalidate yours but I write a lot of code per day and I just run a cleanup tool after to match the teams style - I do a lot of consulation work in big teams and fighting for code-style issue does nothing I feel.

    I prefer to adopt the current guideline and fix real problems and fight real battles like making sure the code is testable from the get go and that OpSec is respected.

  • permalink
  • fedilink
  • source
  • parent