60
A PR replacing the lightmap denoiser just got merged, with big improvements to lighting quality. (github.com)
submitted 3 years ago* (last edited 3 years ago) by to c/godot@programming.dev
6 comments fedilink hide all child comments
 

TL;DR:

Before:

An image showcasing the old de-noiser

After:

An image showcasing the new de-noiser

These images are 2 weeks old and there have been some changes to it, as well as a slider to adjust de-noising. Notice how much more pronounced the ambient occlusion is, and how much better the overall shading is. It's also faster than the older implementation.

On the scene I used for testing this out, the overall rendering time went down from 3 minutes to just over 1 minute in an RTX 3090 Ti with an 8K lightmap.

Bonus: This PR shaves off a massive chunk of the codebase (about 10% apparently.) Expect faster build times and a smaller engine size in 4.2!

An image showing a diff of +304 and -114,449

all 6 comments

sorted by: hot top controversial new old
[–] 12 points 3 years ago (1 child)

Holy shit, 114k lines of code being blown away? That has to be some sort of record for efficiency gain.

I'm interested in comparative gains for lower-specs scenes, like 1k lightmap. Also, was that gain on Vulkan? Have you checked OpenGL 2 and 3, or it won't work with them?

  • permalink
  • fedilink
  • source
  • hideshow 1 child comment
    •
    • [–] 6 points 3 years ago

    Nice to see! I'm using godots lightmap baking for my game and been running into some issues crashes when trying to denoise large light maps, hopefully this fixes that.

  • permalink
  • fedilink
  • source
    •
    [–] 1 point 3 years ago (2 children)

    I see a distinct lack of tests. Is that normal?

  • permalink
  • fedilink
  • source
  • hideshow 2 child comments
    •
  • [–] [S] 1 point 3 years ago (1 child)

    There's been a lot of testing before this got merged, and it got merged to master which isn't stable yet. Next month will be beta builds before 4.2 releases early november, so they'll test many of the newer features and tune it accordingly.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 1 child comment
    •