I use a Nintendo Switch Pro Controller. It does the job for all of the systems I have on Retroarch.
Recently I've been using the 8bitdo Pro 2. It's alright.
Buttons are nice and clicky, but the joysticks seem to have a poorly calibrated dead zone out of the box. Was getting a bit of sick drift on the left side until I made the dead zone a little bit larger.