603
No comment (thelemmy.club)
submitted 3 weeks ago by to c/programminghumor@lemmy.world
50 comments fedilink hide all child comments
 
you are viewing a single comment's thread
view the rest of the comments
[–] 6 points 3 weeks ago (3 children)

A function which is only used once is code smell to me. A function with 200 lines of code and a few comments here and there which I can read from to to bottom can be much more readable than 20 10 line functions for which I have to jump back and forth.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 3 child comments
    •
  • [–] 5 points 3 weeks ago (2 children)

    A 200 line function tells me the code is very likely to be inadequately unit tested and/or is going to be fragile when it's changed in the future.

    Functions aren't only for code reuse, they are for structuring your code.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 2 child comments
    •
  • [–] 2 points 3 weeks ago

    I agree with 200 functions being bad, but breaking them up into private functions won't help you with unit testing, unless you do the other sin of testing private functions. Sometimes you end up with large functions, but when you do it might be a good time to consider creating a new class to spread the responsibilities a bit.

  • permalink
  • fedilink
  • source
  • parent
  • [–] 1 point 3 weeks ago

    In my experience function calls are mostly for breaking my flow of reading. I don't see why you couldn't add structure with newlines and comments.

    It could be that I've only seen bad code and if you do it good it actually improves readability. But I think there's more chance I'll encounter a unicorn than good code.

  • permalink
  • fedilink
  • source
  • parent