Even if that had been what that commenter meant, being willing to die (at someone else's hand) for something you believe in is not even remotely the same as suicidal ideation.

Is it suicide when somebody goes to war for their country despite the very real possibility they may die?

That's what led to today's democracies