197
Git grumpy: Torvalds complains of passive voice in merge commit messages (www.neowin.net)
submitted 2 years ago by to c/programming@programming.dev
48 comments fedilink hide all child comments
 

Linus Torvalds expressed frustration over the use of passive voice in merge commit messages, preferring active and imperative language instead.

He provided an example of how commit messages should be rewritten for clarity and consistency across the project.

Torvalds noted that while it's not a major issue, it does add extra work when he has to rewrite messages to match his preference.

you are viewing a single comment's thread
view the rest of the comments
[–] 47 points 2 years ago* (4 children)

And here it is in the kernel contribution documentation.

Simple example:

  • bad: Added foo interface.
  • good: Add foo interface.

So the commit says what applying the patch will do, not what you worked on.

  • permalink
  • fedilink
  • source
  • hideshow 4 child comments
    •
  • [–] 17 points 2 years ago (2 children)

    good: Add foo interface.

    Another commit style is summarizing what a commit does. In this case it would be someting like:

    Adds foo interface.

    I think this style is more in line with auditing code.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 2 child comments
    •
  • [–] 9 points 2 years ago (1 child)

    This indicative mood is something I would send back for correction or correct myself where I am the maintainer. However I understand that although this is pretty consistent through FOSS, it is not a settled matter especially in corpo-land. Most important is that it is consistent within a project. See many differing views here on Stackoverflow, noting the most popular answer though is imperative as Linus requests.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 1 child comment
    •