it makes me sad that vscode extension api is so specific and constrained that this has to be done as a change to the editor code itself
Not going to lie, pretty good for readability. If they don't merge it maybe give VSCodium a go.
VScodium AFAIK only builds straight from the repo.
So I am not sure if that is possible or not.
I use it though and it is such a relief to be away from microsofts dirty eyes while still using their products.
(Unfortunately, I am using the dart and flutter plugins, so Google still gets the privilege of spying on me, if anyone knows similar plugins without the google crap, do tell me in pm. I disable analytics, but no way this does anything.)
At the same company that immediately backtracked on a an image of a guy wearing a green hat in an installer? Probably.
Real happenings, Zero Bullshit
There was also the santa hat debacle
NOTE: I have zero fucks to give about ether of those specific issues, Iโm just pointing out Microsoft's spine for these things has the consistency of overcooked linguini
If you want that kind of features to be adopted, it's best to the maintainer's input before writing any code.
It's likely for them to want some features on top of what you did (I can think about styling for instance, in which case the name "rainbow" might not be super appropriate?)
(I didn't read the code, maybe you thought about that already)
If the top left window actions can be one color each, then the bottom can too!
What gnome or kde theme is that from?
I'm pretty sure that's originally a macOS thing. Then some design tools adopted it (probably because designers are in the macOS world). I took this from the screenshot in the linked pull request. No idea what they use, but I assumed macOS. Dunno if any Gnome or KDE themes adopt it.
I love you. This answer (while I was playing around suggesting I did not recognize it from macOS) is totally how a wonderful human being would respond. Helpful, kind, assuming the best.
You are truly the person this world needs.
Thank you for the kind words :D
I did not recognize it from macOS
Are you saying it's not from macOS - or at least was not part of the macOS you've actually seen? This thing is many years old, so it wouldn't be a very recent thing.
I don't use or see macOS, though, so my [historical] impression could be wrong (which is why I used subjective/uncertain terminology).
Or by 'suggesting' did you mean you were joking?
I think based on the context of their replies they just live exclusively in Linux and have never noticed the Mac look, or the more likely explanation that it's subtle sarcasm (humor). Both outcomes are great in my opinion lol.