I switched from lastpass to 1Password shortly after they sold to logmein or whatever. I have lately been eyeing the whole suite offered by https://proton.me

I would entertain the idea of using Apple keychain, but I am really hooked on password sharing with the family. Have not seen a good implementation from Apple yet, but maybe it is on the way (or I missed it!).