362
Sublinks Aims to Be a Drop-In Replacement for Lemmy (wedistribute.org)
submitted 2 years ago by to c/fediverse@lemmy.world
308 comments fedilink hide all child comments
 

Seems like an interesting effort. A developer is building an alternative Java-based backend to Lemmy's Rust-based one, with the goal of building in a handful of different features. The dev is looking at using this compatibility to migrate their instance over to the new platform, while allowing the community to use their apps of choice.

you are viewing a single comment's thread
view the rest of the comments
[–] 8 points 2 years ago (7 children)

And what's bad about that? As in, how is the verbosity a negative thing exactly? More so because virtually any tool can be configured to default-collapse these things if for your specific workflow you don't require the information.

At the same time, since everything is verbose, you can get very explicit information if you need it.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 7 child comments
    •
  • [–] 14 points 2 years ago (3 children)

    Here's an example:

    https://github.com/sublinks/sublinks-api/blob/main/src/main/java/com/sublinks/sublinksapi/community/listeners/CommunityLinkPersonCommunityCreatedListener.java

    IMO that's a lot of code (and a whole dedicated file) just to (magically) hook a global event and increase the subscriber count when a link object is added.

    The worst part is that it's all copy/pasted into a neighbouring file which does the reverse:

    https://github.com/sublinks/sublinks-api/blob/main/src/main/java/com/sublinks/sublinksapi/community/listeners/CommunityLinkPersonCommunityDeletedListener.java

    It's not the end of the world or anything, I just think good code should surprise you with its simplicity. This surprises me with its complexity.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 3 child comments
    •
  • [–] 3 points 2 years ago (1 child)

    I find that Java is overly Verbose, but it’s much better than the alternative of underly verbose.

    Java really follows the single class for single functionality principle, so in theory it makes sense to have these located in different classes. It should probably be abstracted to a shared method, but it shouldn’t be in the same file.

    At least to me this looks like simplicity, but I’ve been writing Java in some capacity since 2012.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 1 child comment
    •
  • [–] 6 points 2 years ago

    It's not just the visible complexity in this one file. The point of it is to keep a subscriber count in sync, but you have that code I referenced above, plus:

    LinkPersonCommunityCreatedEvent LinkPersonCommunityDeletedEvent LinkPersonCommunityCreatedPublisher LinkPersonCommunityDeletedPublisher

    And then there are things like LinkPersonCommunityUpdated[Event/Publisher] which don't even seem to be used.

    This is all boilerplate IMO.

    And all of that only (currently) serves keeping that subscriber count up to date.

    And then there's the hidden complexity of how things get wired up with spring.

    And after all that it's still fragile because that event is not tied to object creation:

      @Transactional
  public void addLink(Person person, Community community, LinkPersonCommunityType type) {

    final LinkPersonCommunity newLink = LinkPersonCommunity.builder().community(community)
        .person(person).linkType(type).build();
    person.getLinkPersonCommunity().add(newLink);
    community.getLinkPersonCommunity().add(newLink);
    linkPersonCommunityRepository.save(newLink);
    linkPersonCommunityCreatedPublisher.publish(newLink);
  }

    And there's some code here:

    https://github.com/sublinks/sublinks-api/blob/main/src/main/java/com/sublinks/sublinksapi/api/lemmy/v3/community/controllers/CommunityOwnerController.java#L138C31-L138C50

        final Set<LinkPersonCommunity> linkPersonCommunities = new LinkedHashSet<>();
    linkPersonCommunities.add(LinkPersonCommunity.builder().community(community).person(person)
        .linkType(LinkPersonCommunityType.owner).build());
    linkPersonCommunities.add(LinkPersonCommunity.builder().community(community).person(person)
        .linkType(LinkPersonCommunityType.follower).build());

    communityService.createCommunity(community);

    linkPersonCommunityRepository.saveAllAndFlush(linkPersonCommunities);

    that is able to bypass the community link service and create links in the repository directly, which would presumably not trigger than event.

    Maybe there's a good reason for that, but it sure looks fragile to me.

  • permalink
  • fedilink
  • source
  • parent
  • [–] 3 points 2 years ago

    Yeah but that's more on the coder. Like you indirectly say, they could just as well have had a single listener for community update events, since they all share the data structure for such events (I would assume, haven't looked around too much).

    And to me as a professional java coder, I will say it's just not complex. The scaffolding you mentally discard after a week of working with Java unless you're looking for something related to do the scaffolding - and then it's cool that it's all explicitly there, this has helped me countless times in my career and is one of the big strengths of such verbose languages - and beyond that and some design choices I would not have made that way related to naming and organization, there's not much code there to begin with. In modern Java you might just do this in a lambda supplied in the place where you hook the events, anyways.

  • permalink
  • fedilink
  • source
  • parent
  • [–] 3 points 2 years ago (2 children)

    how is the verbosity a negative thing exactly

    Fun fact, studies have found that the number of bugs in a program is proportional to the number of lines of codes, across languages. More lines of codes, more bugs, even for the same math and edge cases. So a more verbose language tends to have more bugs.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 2 child comments
    •
  • [–] 7 points 2 years ago (1 child)

    Interesting, but did this include web code and code only one person really ever works on?

    Because on the pure backend level, I have observed the reverse over my career. The shorter, the "smarter", the "cooler" the code, the more buggy it is. Not based on the code itself, but based on the developer inevitably leaving the company at some point. Meaning that what matters all of is a sudden is how verbose, how documented and how explicit the code is, because the bugs come from someone else messing with it as they get to take it over. It's a legacy problem in a lot of ways.

    Hence me saying that if solo projects are included, they probably tilt this massively as they'll never really run into this problem. Like say, you just scan github or something. Of course most projects in there are solo, of course the more lines the more room for bugs.
    But in an environment where you're not solo coding, the issue is not getting the code to run and having it have no programmed bugs, but to be able to have someone else understand what you did and wanted to do in a meaningful amount of time, especially as they have to mutate your code over years and decades. Or maybe it's just that the bugs no longer are what "matters", as fixing code bugs is cheap compared to the endless hours wasted from "clever" code being unmaintainable. 🤷

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 1 child comment
    •