27
While reviewing a PR, you find some piece of code that seems to work perfectly well, but some functions are written in a style that you don't particularly favor. What do you do? (cupid.careers)
submitted 2 years ago by to c/experienced_devs@programming.dev
16 comments fedilink hide all child comments
you are viewing a single comment's thread
view the rest of the comments
[–] 12 points 2 years ago

The link refers to it being a style in an area that isn't covered. In that case I'd favour consistency with the current code it's touching and open an issue to update the style guide to cover the new area.

  • permalink
  • fedilink
  • source
    •