611
Dark mode’s bright future: How dark mode will transform Wikipedia’s accessibility (diff.wikimedia.org)
submitted 2 years ago by to c/technology@lemmy.world
113 comments fedilink hide all child comments
you are viewing a single comment's thread
view the rest of the comments
[–] 13 points 2 years ago (3 children)

I don’t mind the pop up as much as I mind it being a pop up that tells you to go to another menu to change the setting. Why not just put the setting in the pop up?

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 3 child comments
    •
  • [–] -1 points 2 years ago (2 children)

    Thats how you get spaghetti code.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 2 child comments
    •
  • [–] 6 points 2 years ago

    It's really not that complicated.

    You give the information on where the setting is, then have an "enable now" button that calls the exact same function as clicking the toggle on the other page does. Having multiple ways to do the same thing isn't unusual and is trivial with properly designed code.

  • permalink
  • fedilink
  • source
  • parent
  • [–] 2 points 2 years ago

    No. It isn't. The setting in the modal should act as a convenience component that doesn't have any of its own data. It only modifies the value in the original source of truth. Once the modal has been used, it should never pop up again, as the assumption will be if the user has interacted with the modal, they are now aware of the setting and can set it themselves from the original source of truth. Unless of course you consider any feature speghettification

  • permalink
  • fedilink
  • source
  • parent